Refactoring textual representation of specs#6
Open
m-a-r-c-e-l-i-n-o wants to merge 1 commit intoappacademy:masterfrom
Open
Refactoring textual representation of specs#6m-a-r-c-e-l-i-n-o wants to merge 1 commit intoappacademy:masterfrom
m-a-r-c-e-l-i-n-o wants to merge 1 commit intoappacademy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I don't mean to boggle anyone down with technicalities (no breakthroughs here), but I was wondering why the default textual output for the specs seem to lack a bit of consistency. If not for internal evaluation reasons, why not follow some sort of predicable format? Below are before and after images illustrating a possible improvement.
Before:

After:

For now, I've just made a few simple changes:
I feel that this is important because it shows a clear distinction of where one test starts and another ends, and what subsection it pertains to. This would allow for a quicker analysis.
Unlike the rest, the "10_temperature_object_spec.rb" spec follows a very human-linguist style, so I left it mostly alone until further discussion.